Fix contrast issues with color overrides #9
Conversation
|
I used https://webaim.org/resources/contrastchecker/ and Firefox's accessibility checker (Shift+F12) to look for issues. Original sphinx-lesson implementationhttps://coderefinery.github.io/sphinx-lesson/directives/. Overrides: before this PR
Overrides: after this PR
|
| } | ||
|
|
||
| /* discussion */ | ||
| .rst-content .discussion { | ||
| background: rgba(231, 212, 232 0.3); | ||
| background: rgba(231, 212, 232, 0.3); |
|
224e7e3 also fixes Before
After
|
|
Perhaps Apostolos recalls the context and can also comment on the colors. |
|
I like the general vibe of how it looks now. My only doubt is about the question call-out, that red breaks a bit the general pastel tone of the other colours. |
|
True. I only made the questions colour darker to meet the 7:1 contrast criterion. Pastel colour is not possible with white text, but I can look for a pinkish colour |
|
In ba23d21 I fixed these directive which are seldom used. May not be the best color choices, but at least it is readable now. Before
After
|
The commit fbdbc8a added a few color overrides over what sphinx-lesson provides.
I don't know what the original purpose of this implementation was. It seems the intention was to distinguish different overrides. However there are contrast issues and a missing comma, which I am trying to rectify here.